Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use test-queue to run tests on JRuby because it doesn't support fork #296

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Don't use test-queue to run tests on JRuby because it doesn't support fork #296

merged 1 commit into from
Jan 4, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 3, 2024

Follow up to #294

Currently this is aimed at being the most straightforward if probably slightly inelegant way to get tests running on JRuby - I assume there is probably a slightly cleaner way of invoking tests but I don't yet know what it is and Rake::TestTask was more than a few lines of code 😅

I think it would be worth considering having test-queue "support" JRuby by not using fork if that platform is detected or if you set TEST_QUEUE_WORKERS to 1 (or maybe 0?) as a way of making it easier to have a normalized way of invoking tests across different platforms like this; but it would also be equally valid I think for test-queue to say that's out of scope for the gem🤷


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Rakefile Outdated Show resolved Hide resolved
@G-Rath G-Rath requested a review from koic January 4, 2024 18:12
@koic koic merged commit 9a7a882 into rubocop:master Jan 4, 2024
13 checks passed
@koic
Copy link
Member

koic commented Jan 4, 2024

Thanks!

@G-Rath G-Rath deleted the fix-jruby-ci branch January 4, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants